[port] fix(agentic): Align changelog configs with legend / 统一 Agentic 变更记录与图例配置名称#608
Merged
Merged
Conversation
Reuse the canonical chart hardware-key and display-label path for changelog config formatting and modified-config highlighting. Add regression coverage for agentic HiCache suffixes. 中文:统一变更记录与图例中的配置名称;复用规范化硬件 key 和显示名称逻辑,并修复 Agentic HiCache 配置的红色高亮。新增对应的回归测试。
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port note
Ports the exact three-file patch from #603 onto
master. #603 was merged only into the now-defunctfeat/agentxbranch and therefore was not included in the separate #604 → #607 port.Summary
Root cause and impact
Agentic changelog keys append scenario metadata such as
agentic-hicacheafter the framework. The old formatter treated those suffixes as part of the framework name, producing labels such asVLLM AGENTIC, and the highlight path failed to match the legend key.After this change, the changelog uses the same canonical label as the legend and highlights the corresponding modified configuration correctly.
Validation
git diff --check中文说明
移植说明
将 #603 的完整三文件补丁移植到
master。#603 仅合并到了现已弃用的feat/agentx分支,因此未包含在另一个 #604 → #607 移植中。概要
根因与影响
Agentic 变更记录的 config key 会在 framework 后附加
agentic-hicache等场景元数据。旧 formatter 将这些后缀误当作 framework 名称的一部分,因此产生VLLM AGENTIC等标签,并且高亮逻辑无法匹配图例 key。本次改动后,变更记录会使用与图例一致的规范化名称,并正确高亮对应的已修改配置。
验证
git diff --checkNote
Low Risk
Localized changelog/legend formatting and highlight logic with new unit tests; no auth, data, or API changes.
Overview
Agentic changelog config keys append scenario metadata (e.g.
agentic-hicache) after the serving framework. The PR introduceschangelogConfigToHwKeyto map those keys to the same canonicalhwKeythe scatter chart and legend use, stripping scenario suffixes while preservingmtpwhen present.Changelog UI now builds “Updated Configs” labels via
getHardwareConfig/getDisplayLabel(same as the legend) instead of treating trailing tokens as framework names.configKeyMatchesHwKeydelegates to the new parser, so comparison changelog GPU filtering stays consistent.Scatter legend highlighting for modified configs switches from hyphen-suffix matching to a
Setof canonical hw keys derived from changelog entries, restoring red highlight for agentic configs that previously failed to match.Reviewed by Cursor Bugbot for commit 872f34b. Bugbot is set up for automated code reviews on this repo. Configure here.